Logging loop with n log sentry

[SimonCropp]

• Repro
• Fixes Logging loop with NLog-Sentry #1741 Failed to extract body - NullReferenceException #1701

although this is not the exact scenario as #1741 as #1701, it is the same root cause. essentially when inside logging we have anything that causes a log event it results in an infinite loop. in #1701

• NLog.SentryTarget.Write occurs
• Scope.Evaluate occurs
• triggering AspNetCore.SentryMiddleware which is failing
• triggering NLog.SentryTarget.Write
• repeat

[bruno-garcia]

Thank you for fixing this Simon!

[SimonCropp]

i work around this with an asynclocal. can anyone think of a better approach?

[mattjohnsonpint]

i work around this with an asynclocal. can anyone think of a better approach?

Yes. We can use NLog's built-in context for this. See my update, and LMK if you agree. Thanks.

[SimonCropp]

@mattjohnsonpint much nicer. thanks

[snakefoot]

Think it is a bad idea to "abuse" the NLog ScopeContext to protect against bad calling pattern. The NLog ScopeContext is for the user to capture application-state, not for secret infrastructure problems. Just like you hopefully won't "abuse" the Serilog LogContext for injecting special context values.

If you really insist on abusing the NLog NestedDiagnosticsLogicalContext, then you should render the Sentry-LogEvent outside this secret-scope. As layouts depending on ${ndlc} will have side-effects from this usage.

But I recommend that you keep the special infrastructure problems secret, and use a local AsyncLocal-member-variable.

[mattjohnsonpint]

@snakefoot that's a good point.

@SimonCropp - let's go back to the async local approach you had. Thanks.

[SimonCropp]

done #1830