Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and configure options for the iOS SDK #1849

Merged
merged 28 commits into from Aug 14, 2022
Merged

Add and configure options for the iOS SDK #1849

merged 28 commits into from Aug 14, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Aug 12, 2022

  • Sets the default options for the Cocoa SDK
  • Added several internal extension methods to deal with various mappings between .NET and Objective-C data types
  • Connect BeforeBreadcrumb on the Cocoa SDK
  • Prevented duplicate events on unhandled managed crash by filtering out the corresponding native SIGABRT event

A few minor fixes along the way:

  • Fixed the MAUI sample app crashing on startup on iOS
  • Updated some #if statements
  • Fixed some typos
  • Set defaults explicitly for the Android options
  • Fixed a bug with DefaultTags being duplicated in the Android SDK
  • Aliased a few common types

Next to do (separate PRs coming for these)

  • Finish connecting BeforeSend and OnCrashedLastRun, both which need SentryEvent to/from working.
    • Started on this - code is commented out in this PR.
  • Gather device and context info in IosScopeObserver
  • Need to move the Distribution option into the main SDK.

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) August 14, 2022 16:55
@mattjohnsonpint mattjohnsonpint merged commit 40ec0d8 into main Aug 14, 2022
@mattjohnsonpint mattjohnsonpint deleted the ios-options branch August 14, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants