Add Distribution properties to go along with Release info
#1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Env vars are leaking. I'll fix soon. |
SimonCropp
reviewed
Aug 13, 2022
SimonCropp
reviewed
Aug 13, 2022
SimonCropp
reviewed
Aug 13, 2022
|
This is ready. Default values for release and distribution for Android and iOS will come in a separate PR after this is merged. |
SimonCropp
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://develop.sentry.dev/sdk/event-payloads/#optional-attributes
We had
release, but notdistbecause it's usually used only in mobile apps. For one example usage, see our React Native docs.We need this now, since we have the embedded Android and iOS SDKs. However, for various reasons, it was much easier to make it an optional value available to all targets.