Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore null context values #1942

Merged
merged 7 commits into from
Sep 27, 2022
Merged

ignore null context values #1942

merged 7 commits into from
Sep 27, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Sep 22, 2022 •
edited
Loading

fix for #1332

@getsentry getsentry deleted a comment from github-actions bot Sep 22, 2022
@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Sep 23, 2022 •
edited
Loading

Please also add a test that ensures the length header of the envelope comes out correctly, since that was the issue originally reported. Thanks.

@SimonCropp
Copy link
Contributor Author

@mattjohnsonpint

Please also add a test that ensures the length header of the envelope comes out correctly, since that was the issue originally reported. Thanks.

done

@mattjohnsonpint
Copy link
Contributor

Test is failing

@SimonCropp
Copy link
Contributor Author

test fixed

@mattjohnsonpint mattjohnsonpint merged commit d4eccd3 into main Sep 27, 2022
@mattjohnsonpint mattjohnsonpint deleted the ignore-null-context-values branch September 27, 2022 15:55
@mattjohnsonpint mattjohnsonpint linked an issue Sep 29, 2022 that may be closed by this pull request
invalid event envelope. Error causes: unexpected end of file. If Context is null #1332
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid event envelope. Error causes: unexpected end of file. If Context is null
2 participants
@SimonCropp @mattjohnsonpint