Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude EF error messages from logging #1980

Merged
merged 12 commits into from
Oct 13, 2022
Merged

Exclude EF error messages from logging #1980

merged 12 commits into from
Oct 13, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Oct 10, 2022

fixes #454

@bruno-garcia was this what u had in mind?

@SimonCropp SimonCropp changed the title Exclude EF error message from logging Exclude EF error messages from logging Oct 10, 2022
@mattjohnsonpint
Copy link
Contributor

Looks like the test failure is in verify tests that contain a version number:

-           Message: Entity Framework Core 6.0.8 initialized 'TestDbContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer:6.0.8' with options: NoTracking ,
+           Message: Entity Framework Core 6.0.9 initialized 'TestDbContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer:6.0.9' with options: NoTracking ,

We should probably scrub/ignore those.

@SimonCropp SimonCropp merged commit cc17ab4 into main Oct 13, 2022
@SimonCropp SimonCropp deleted the add-logging-ef-test branch October 13, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out EF Core internal log in Sentry.Extensions.Logging
2 participants