Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github actions #1985

Merged
merged 8 commits into from Oct 28, 2022
Merged

Update github actions #1985

merged 8 commits into from Oct 28, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Oct 13, 2022 •
edited

A few improvements to our GitHub Actions workflows:

  • Install Ninja directly (via brew, choco, or apt-get), as the action we were previously using appears to be not getting updates and is giving a node12 warning
  • Remove DOTNET_INSTALL_DIR from the .NET install action, as it's no longer needed with v3
  • Update the device tests to run on macos-12, use the latest android emulator action, and install/use HAXM
  • Fix the broken restore in the vulnerabilities check workflow

#skip-changelog

@mattjohnsonpint mattjohnsonpint changed the title Update dependencies Update github actions Oct 13, 2022
@mattjohnsonpint mattjohnsonpint force-pushed the update-dependencies branch 2 times, most recently from 9cbed8b to 1903b5f Compare October 28, 2022 19:14
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review October 28, 2022 19:44
vaind
vaind approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/actions/buildnative/action.yml Outdated Show resolved Hide resolved
.github/workflows/device-tests.yml Outdated Show resolved Hide resolved
mattjohnsonpint and others added 4 commits October 28, 2022 14:02
@mattjohnsonpint @vaind
Update .github/actions/buildnative/action.yml
6d380d8 
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
@mattjohnsonpint @vaind
Update .github/workflows/device-tests.yml
b93153f 
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
@mattjohnsonpint
Setup Homebrew
bbe95e5
@mattjohnsonpint
.
c41127b
@mattjohnsonpint mattjohnsonpint merged commit ff194db into main Oct 28, 2022
@mattjohnsonpint mattjohnsonpint deleted the update-dependencies branch October 28, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattjohnsonpint @vaind