Build Windows and Tizen targets for Sentry.Maui
#2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to access certain MAUI APIs, we need to always be able to conditionally target all supported MAUI platforms. Currently we ship the NuGet package with separate targets for Android, iOS, and MacCatalyst only. We need to add Windows and Tizen to that list.
With this PR, the Windows target will also now build on macOS where we package the NuGet. We can do this for class libraries only, as we don't have the actual WinUI3 runtime available.
We also add the Tizen target, but conditionally include it only if the Tizen workloads are present, as to not create yet another required developer dependency. We also now install the minimum Tizen workloads in the CI build.