Fix trace propagation targets setter #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
approved these changes
Nov 9, 2022
bitsandfoxes
reviewed
Nov 9, 2022
Comment on lines
+599
to
+601
| // NOTE: During configuration binding, .NET 6 and lower used to just call Add on the existing item. | ||
| // .NET 7 changed this to call the setter with an array that already starts with the old value. | ||
| // We have to handle both cases. |
There was a problem hiding this comment.
That sounds like a huge gotcha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing with .NET 7 (in #1952), I found that configuration bindings for lists have changed. It used to be that an existing list would have its
Addmethod called to incorporate items during binding. Now it appears the whole list is replaced.With
SentryOptions.TracePropagationTargets, we use[".*"]by default. If the user provides a different list via config, or adds to the existing list in code, we have to clear the wildcard automatically.With these changes, we now do this correctly for both adding to this or replacing the list - so it works correctly on all targets and we don't have to make any assumptions about configuration binding behavior per version.