Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CacheDirectoryPath option on MAUI #2055

Merged
merged 4 commits into from Nov 17, 2022
Merged

Conversation

mattjohnsonpint
Copy link
Contributor

We were overwriting the user's setting with the default.

Fixes #2052

Also:

  • Removed the extra /sentry in the default cache path, because we already add one when the caching transport is invoked anyway.
  • Improved some internals

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review November 17, 2022 20:04
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) November 17, 2022 20:05
@mattjohnsonpint mattjohnsonpint merged commit 6e79a94 into main Nov 17, 2022
@mattjohnsonpint mattjohnsonpint deleted the fix-maui-cachepath branch November 17, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants