Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important NLog integration configuration fixes #207

Merged
merged 3 commits into from May 27, 2019

Conversation

josh-degraw
Copy link
Contributor

This pull request does the following:

  • Removes the RequiredParameterAttribute from the SentryTarget.Dsn.
  • Pulls up all direct properties on SentryNLogOptions to members of SentryTarget
  • Adds/modifies some xml doc comments on these members.

@josh-degraw josh-degraw changed the title Pulled up properties from SentryNLogOptions onto SentryTarget Important NLog integration configuration fixes May 26, 2019
@bruno-garcia bruno-garcia merged commit 8ba2027 into getsentry:master May 27, 2019
@bruno-garcia
Copy link
Member

@josh-degraw THanks again for your contributions!
I'll release a review soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants