New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli integration on Windows #2123

Merged

mattjohnsonpint merged 2 commits into main from fix-cli-windows

Jan 24, 2023

Contributor

mattjohnsonpint commented Jan 24, 2023

Needed to add .exe on the cli commands for Windows to pass Exists checks
Needed to use double quotes encoded as " instead of single quotes, when wrapping commands, paths, or arguments


          Fix cli integration on Windows

5c92ea1

mattjohnsonpint requested a review from bitsandfoxes as a code owner

January 24, 2023 01:31


          Update CHANGELOG.md

74fdb10

mattjohnsonpint requested review from bruno-garcia and vaind

January 24, 2023 01:33

bruno-garcia approved these changes

View reviewed changes

mattjohnsonpint merged commit 9747a78 into main

mattjohnsonpint deleted the fix-cli-windows branch

January 24, 2023 03:16

mattjohnsonpint mentioned this pull request

Fix cli integration on Windows #2124

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment