Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assembly not found on Android in Debug configuration #2175

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Fix assembly not found on Android in Debug configuration #2175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6242677
Use assembly if it's already on disk
mattjohnsonpint Feb 10, 2023
ac8803e
Update CHANGELOG.md
mattjohnsonpint Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Fix assembly not found on Android in Debug configuration ([#2175](https://github.com/getsentry/sentry-dotnet/pull/2175))

## 3.28.1

### Fixes
Expand Down
7 changes: 7 additions & 0 deletions src/Sentry.Android.AssemblyReader/AndroidAssemblyDirectoryReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ public AndroidAssemblyDirectoryReader(ZipArchive zip, IList<string> supportedAbi

public PEReader? TryReadAssembly(string name)
{
if (File.Exists(name))
{
// The assembly is already extracted to the file system. Just read it.
var stream = File.OpenRead(name);
return new PEReader(stream);
}

var zipEntry = FindAssembly(name);
if (zipEntry is null)
{
Expand Down