Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BeforeSendTransaction #2188

Merged
merged 10 commits into from Feb 27, 2023

Conversation

SeanFeldman
Copy link
Contributor

@SeanFeldman SeanFeldman commented Feb 17, 2023

Add BeforeSendTransaction to work similarly to BeforeSend but for transactions instead of events.

Fixes #2077

Copy link
Contributor Author

@SeanFeldman SeanFeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While still a WIP, I have a few questions.

src/Sentry/SentryClient.cs Outdated Show resolved Hide resolved
test/Sentry.Tests/SentryClientTests.verify.cs Show resolved Hide resolved
@SeanFeldman SeanFeldman force-pushed the 2077-add-support-for-BeforeSendTransaction branch from e6885db to 4be0d0d Compare February 24, 2023 05:34
@SeanFeldman SeanFeldman marked this pull request as ready for review February 24, 2023 05:36
@SeanFeldman SeanFeldman force-pushed the 2077-add-support-for-BeforeSendTransaction branch from 4be0d0d to 78b01c0 Compare February 24, 2023 05:43
@mattjohnsonpint
Copy link
Contributor

LGTM! 🚀

@mattjohnsonpint mattjohnsonpint merged commit 68f368e into main Feb 27, 2023
@mattjohnsonpint mattjohnsonpint deleted the 2077-add-support-for-BeforeSendTransaction branch February 27, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BeforeSendTransaction
3 participants