Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scope.Clear and Scope.ClearBreadcrumbs methods #2284

Merged
merged 4 commits into from Apr 6, 2023
Merged

Add Scope.Clear and Scope.ClearBreadcrumbs methods #2284

merged 4 commits into from Apr 6, 2023

Conversation

jamescrosswell
Copy link
Collaborator

Resolves #2272

@mattjohnsonpint
Copy link
Contributor

Thanks for the PR! I'll review soon and get back to you. 🙂

mattjohnsonpint
mattjohnsonpint suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall! A few things to address as indicated inline.

Also:

  • After you switch the methods public, re-run tests locally and you'll see the public API snapshots have been updated. Commit those. (You can use dotnet test test/Sentry.Tests --filter ApiApprovalTests if you want to do it fast. Or just run all tests.)
  • Add an entry to CHANGELOG.md, pointing back at this PR.

Thanks!

src/Sentry/Scope.cs Outdated Show resolved Hide resolved
src/Sentry/Scope.cs Outdated Show resolved Hide resolved
src/Sentry/Scope.cs Outdated Show resolved Hide resolved
test/Sentry.Tests/ScopeTests.cs Show resolved Hide resolved
test/Sentry.Tests/ScopeTests.cs Show resolved Hide resolved
test/Sentry.Tests/ScopeTests.cs Show resolved Hide resolved
@jamescrosswell
- updated Clear and ClearBreadcrumbs methods to be public
194315e 
- Provided summary documentation for the ClearBreadcrumbs method
- Committed updated verified.txt files for API approval tests
@jamescrosswell
Added details of Scope.Clear and Scope.ClearBreadcrumbs to changelog
dcc17a4
@jamescrosswell
- Added test to ensure Scope.Clear doesn't affect parent scopes in th…
7de046f 
…e SentryScopeManager

- Added extension method to set fake values on a Scope during testing
- Added extension method to ensure Scopes are equivalent during testing
@mattjohnsonpint
Copy link
Contributor

Nice job. Thanks!!!

@mattjohnsonpint mattjohnsonpint merged commit 0f9a0fd into getsentry:main Apr 6, 2023
14 checks passed
@jamescrosswell jamescrosswell mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Scope.Clear and Scope.ClearBreadcrumbs
2 participants
@jamescrosswell @mattjohnsonpint