Rework handling of AggregateException to align with Sentry Exception Groups
#2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Rework handling of `AggregateException` to align with Sentry Exception Groups ([#2287](https://github.com/getsentry/sentry-dotnet/pull/2287))If none of the above apply, you can opt out of this check by adding |
mattjohnsonpint
changed the title
AggregateException to align with Sentry Exception Groups
mattjohnsonpint
force-pushed
the
feat/exception-groups
branch
from
8ec5042
to
c8bbb04
Compare
mattjohnsonpint
force-pushed
the
feat/exception-groups
branch
3 times, most recently
from
b485a46
to
2c65ad7
Compare
mattjohnsonpint
force-pushed
the
feat/exception-groups
branch
from
2c65ad7
to
09d946a
Compare
|
Reminder to self: Update changelog before publishing to include note about which Sentry version this is compatible with. |
SeanFeldman
approved these changes
Apr 13, 2023
jamescrosswell
approved these changes
May 2, 2023
|
This can be shipped as soon as getsentry/sentry#48653 is completed and released to production. Also, for the best experience with exception groups, self-hosted Sentry users should take the corresponding update when it is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the .NET SDK to align with the new "exception groups" feature of Sentry. See #2240, and Sentry RFC 79 for details.
Aligns with full changes listed at getsentry/sentry#37716 (comment)
This changes how
AggregateExceptionis handled. Instead of filtering them out client-side, the SDK marks them as an "exception group", and adds includes data that represents the hierarchical structure of inner exceptions. Sentry now recognizes this server-side, improving the accuracy of the issue detail page.Accordingly, the
KeepAggregateExceptionoption is now obsolete and does nothing. Please remove any usages ofKeepAggregateException.NOTE: If running Self-Hosted Sentry, you should wait to adopt this SDK update until after updating to the 23.6.0 (est. June 2023) release of Sentry. The effect of updating the SDK early will be as if
KeepAggregateException = truewas set. That will not break anything, but may affect issue grouping and alerts.Closes #2240.