Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.5.0 #2310

Merged
merged 3 commits into from
Apr 18, 2023
Merged

chore(deps): update Cocoa SDK to v8.5.0 #2310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6f68dd
chore: update modules/sentry-cocoa to 8.5.0
web-flow Apr 18, 2023
b2b1329
Update generate-cocoa-bindings.ps1
mattjohnsonpint Apr 18, 2023
ddd77cb
Update ApiDefinitions.cs
mattjohnsonpint Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
- Bump CLI from v2.17.0 to v2.17.2 ([#2298](https://github.com/getsentry/sentry-dotnet/pull/2298))
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2172)
- [diff](https://github.com/getsentry/sentry-cli/compare/2.17.0...2.17.2)
- Bump Cocoa SDK from v8.4.0 to v8.5.0 ([#2310](https://github.com/getsentry/sentry-dotnet/pull/2310))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#850)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.4.0...8.5.0)

## 3.30.0

Expand Down
2 changes: 1 addition & 1 deletion modules/sentry-cocoa
Open in desktop
Submodule sentry-cocoa updated 253 files
6 changes: 5 additions & 1 deletion scripts/generate-cocoa-bindings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Set-StrictMode -Version Latest
$ErrorActionPreference = 'Stop'

$RootPath = (Get-Item $PSScriptRoot).Parent.FullName
$CocoaSdkPath = "$RootPath/modules/sentry-cocoa"
Expand All @@ -21,9 +22,12 @@ if (!(Get-Command sharpie -ErrorAction SilentlyContinue)) {
-CategoryActivity Error -ErrorAction Stop
}

# Get iPhone SDK version
$iPhoneSdkVersion = sharpie xcode -sdks | grep -o 'iphoneos\S*'

# Generate bindings
Write-Output 'Generating bindings with Objective Sharpie.'
sharpie bind -sdk iphoneos -quiet `
sharpie bind -sdk $iPhoneSdkVersion -quiet `
-scope "$CocoaSdkPath/Carthage/Headers" `
"$CocoaSdkPath/Carthage/Headers/Sentry.h" `
"$CocoaSdkPath/Carthage/Headers/PrivateSentrySDKOnly.h" `
Expand Down
9 changes: 7 additions & 2 deletions src/Sentry.Bindings.Cocoa/ApiDefinitions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2124,8 +2124,8 @@ interface SentryTraceContext : SentrySerializable
[NullAllowed, Export ("userSegment")]
string UserSegment { get; }

// @property (nonatomic) NSString * _Nullable sampleRate;
[NullAllowed, Export ("sampleRate")]
// @property (nonatomic, strong) NSString * _Nullable sampleRate;
[NullAllowed, Export ("sampleRate", ArgumentSemantic.Strong)]
string SampleRate { get; set; }

// -(instancetype _Nonnull)initWithTraceId:(SentryId * _Nonnull)traceId publicKey:(NSString * _Nonnull)publicKey releaseName:(NSString * _Nullable)releaseName environment:(NSString * _Nullable)environment transaction:(NSString * _Nullable)transaction userSegment:(NSString * _Nullable)userSegment sampleRate:(NSString * _Nullable)sampleRate;
Expand Down Expand Up @@ -2354,6 +2354,11 @@ interface PrivateSentrySDKOnly
[Export ("getSdkVersionString")]
string SdkVersionString { get; }

// +(NSDictionary * _Nonnull)getExtraContext;
[Static]
[Export ("getExtraContext")]
NSDictionary ExtraContext { get; }

// @property (copy, nonatomic, class) SentryOnAppStartMeasurementAvailable _Nullable onAppStartMeasurementAvailable;
[Static]
[NullAllowed, Export ("onAppStartMeasurementAvailable", ArgumentSemantic.Copy)]
Expand Down