Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cocoa Bindings Failure #2312

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix Cocoa Bindings Failure #2312

merged 1 commit into from
Apr 19, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Apr 18, 2023 •
edited

This fixes the failing build. Basically, was a simple error on my part with script changes added in #2310 because the grep command returned multiple results in CI:

iphoneos16.1
iphoneos16.0
iphoneos15.5
iphoneos15.4
iphoneos15.2
iphoneos15.0

We only want the first match, which is what -m 1 gives.

#skip-changelog

@mattjohnsonpint mattjohnsonpint changed the title WIP - Debugging Cocoa Bindings CI failure Fix Cocoa Bindings Failure Apr 19, 2023
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review April 19, 2023 00:07
@mattjohnsonpint mattjohnsonpint merged commit 10ddff1 into main Apr 19, 2023
16 checks passed
@mattjohnsonpint mattjohnsonpint deleted the fix/cocoa-bindings branch April 19, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanFeldman SeanFeldman SeanFeldman approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattjohnsonpint @SeanFeldman