Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Cocoa SDK to v8.7.0 #2359

Merged
merged 5 commits into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

- Add tag filters to SentryLoggingOptions ([#2360](https://github.com/getsentry/sentry-dotnet/pull/2360))

### Dependencies

- Bump Cocoa SDK from v8.6.0 to v8.7.0 ([#2359](https://github.com/getsentry/sentry-dotnet/pull/2359))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#870)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.6.0...8.7.0)

## 3.31.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion modules/sentry-cocoa
Submodule sentry-cocoa updated 50 files
+24 −0 .codecov.yml
+0 −25 .github/.codecov.yml
+2 −2 .github/workflows/codeql-analysis.yml
+48 −28 .github/workflows/test.yml
+6 −2 .github/workflows/testflight.yml
+4 −0 .spi.yml
+37 −1 CHANGELOG.md
+5 −0 Samples/iOS-ObjectiveC/iOS-ObjectiveC/AppDelegate.m
+12 −4 Samples/iOS-Swift/iOS-Swift.xcodeproj/project.pbxproj
+21 −14 Samples/iOS-Swift/iOS-Swift/AppDelegate.swift
+92 −19 Samples/iOS-Swift/iOS-Swift/Base.lproj/Main.storyboard
+0 −17 Samples/iOS-Swift/iOS-Swift/Tools/RandomErrors.swift
+52 −0 Samples/iOS-Swift/iOS-Swift/ViewControllers/UIEventBreadcrumbsController.swift
+40 −0 Samples/iOS-Swift/iOS-SwiftUITests/UIEventBreadcrumbTests.swift
+10 −8 Samples/macOS-Swift/macOS-Swift/AppDelegate.swift
+9 −8 Samples/tvOS-Swift/tvOS-Swift/AppDelegate.swift
+2 −2 Sentry.podspec
+4 −2 Sentry.xcodeproj/project.pbxproj
+3 −0 Sentry.xcodeproj/xcshareddata/xcschemes/Sentry.xcscheme
+1 −1 SentryPrivate.podspec
+2 −2 SentrySwiftUI.podspec
+1 −1 Sources/Configuration/Sentry.xcconfig
+1 −1 Sources/Configuration/SentryPrivate.xcconfig
+9 −9 Sources/Sentry/Public/SentryOptions.h
+5 −1 Sources/Sentry/Public/SentrySDK.h
+14 −4 Sources/Sentry/SentryClient.m
+0 −6 Sources/Sentry/SentryCrashIntegration.m
+4 −0 Sources/Sentry/SentryCrashWrapper.m
+15 −29 Sources/Sentry/SentryFramesTracker.m
+1 −1 Sources/Sentry/SentryMeta.m
+7 −4 Sources/Sentry/SentryOptions.m
+3 −1 Sources/Sentry/SentrySDK.m
+1 −0 Sources/Sentry/SentryScope.m
+32 −30 Sources/SentryCrash/Recording/SentryCrash.m
+5 −0 Sources/Swift/SwiftDescriptor.swift
+6 −5 Tests/SentryTests/Helper/SentryDeviceTests.mm
+0 −48 Tests/SentryTests/Integrations/Breadcrumbs/SentryBreadcrumbTrackerTests.swift
+0 −42 Tests/SentryTests/Integrations/Performance/FramesTracking/SentryFramesTrackerTests.swift
+1 −27 Tests/SentryTests/Integrations/SentryCrash/SentryCrashIntegrationTests.swift
+0 −3 Tests/SentryTests/Networking/RateLimits/SentryConcurrentRateLimitsDictionaryTests.swift
+81 −9 Tests/SentryTests/SentryClientTests.swift
+13 −0 Tests/SentryTests/SentryCrash/SentryCrashTests.m
+1 −16 Tests/SentryTests/SentryCrash/SentryStacktraceBuilderTests.swift
+0 −5 Tests/SentryTests/SentryCrash/SentryThreadInspectorTests.swift
+17 −7 Tests/SentryTests/SentryOptionsTest.m
+15 −0 Tests/SentryTests/SentrySDKTests.swift
+31 −0 Tests/SentryTests/SentryScopeSwiftTests.swift
+0 −30 Tests/SentryTests/SentryScopeTests.m
+41 −0 Tests/SentryTests/SwiftDescriptorTests.swift
+1 −0 scripts/ci-select-xcode.sh
8 changes: 4 additions & 4 deletions src/Sentry.Bindings.Cocoa/ApiDefinitions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -712,10 +712,6 @@ interface SentryOptions
[Export ("attachStacktrace")]
bool AttachStacktrace { get; set; }

// @property (assign, nonatomic) BOOL stitchAsyncCode;
[Export ("stitchAsyncCode")]
bool StitchAsyncCode { get; set; }

// @property (assign, nonatomic) NSUInteger maxAttachmentSize;
[Export ("maxAttachmentSize")]
nuint MaxAttachmentSize { get; set; }
Expand All @@ -728,6 +724,10 @@ interface SentryOptions
[Export ("enableAutoPerformanceTracing")]
bool EnableAutoPerformanceTracing { get; set; }

// @property (nonatomic) SentryScope * _Nonnull (^ _Nonnull)(SentryScope * _Nonnull) initialScope;
[Export ("initialScope", ArgumentSemantic.Assign)]
Func<SentryScope, SentryScope> InitialScope { get; set; }

// @property (assign, nonatomic) BOOL enableUIViewControllerTracing;
[Export ("enableUIViewControllerTracing")]
bool EnableUIViewControllerTracing { get; set; }
Expand Down
10 changes: 3 additions & 7 deletions src/Sentry/Platforms/iOS/SentryOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -253,16 +253,12 @@ public bool EnableUIViewControllerTracking
public bool EnableUserInteractionTracing { get; set; } = false;

/// <summary>
/// This feature is experimental.
/// Turning this feature on can have an impact on the grouping of your issues.
/// When enabled, the Cocoa SDK stitches stack traces of asynchronous code together.
/// This feature affects stack traces from native crashes only.
/// The default value is <c>false</c> (disabled).
/// This feature is no longer available. This option does nothing and will be removed in a future release.
/// </summary>
/// <remarks>
/// Official docs TBD.
/// See https://github.com/getsentry/sentry-docs/issues/5215
/// This was removed from the Cocoa SDK in 8.6.0 with https://github.com/getsentry/sentry-cocoa/pull/2973
/// </remarks>
[Obsolete("This feature is no longer available. This option does nothing and will be removed in a future release.")]
public bool StitchAsyncCode { get; set; } = false;

// /// <summary>
Expand Down
4 changes: 3 additions & 1 deletion src/Sentry/Platforms/iOS/SentrySdk.cs
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,11 @@ private static void InitSentryCocoaSdk(SentryOptions options)
cocoaOptions.EnableSwizzling = options.iOS.EnableSwizzling;
cocoaOptions.EnableUIViewControllerTracing = options.iOS.EnableUIViewControllerTracing;
cocoaOptions.EnableUserInteractionTracing = options.iOS.EnableUserInteractionTracing;
cocoaOptions.StitchAsyncCode = options.iOS.StitchAsyncCode;
cocoaOptions.UrlSessionDelegate = options.iOS.UrlSessionDelegate;

// StitchAsyncCode removed from Cocoa SDK in 8.6.0 with https://github.com/getsentry/sentry-cocoa/pull/2973
// cocoaOptions.StitchAsyncCode = options.iOS.StitchAsyncCode;

// In-App Excludes and Includes to be passed to the Cocoa SDK
options.iOS.InAppExcludes?.ForEach(x => cocoaOptions.AddInAppExclude(x));
options.iOS.InAppIncludes?.ForEach(x => cocoaOptions.AddInAppInclude(x));
Expand Down