Reduce debug files uploaded #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanFeldman
approved these changes
Jun 1, 2023
|
Note, the tests don't really show it, but on a WinUI app, this reduces from hundreds of debug files down to just a handful - because there are lots of native |
SeanFeldman
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
<SentryUploadSymbols>istrue, we usesentry-clito upload any valid debug info file from the output directory. Unfortunately, that also picks up every.so,.dlland.exebecause they can contain native stack unwind details and symbol tables. For most .NET projects, we only need the.pdbfiles. We also need thedsymfiles (.dylib, etc.) on iOS/MacCatalyst.This PR updates our msbuild target to only include the symbol files that are needed per platform.