Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding proguard rules to Sentry.Bindings.Android #2450

Merged
merged 10 commits into from Jun 27, 2023

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jun 26, 2023

Resolves #2376
The SDK is looking up the native methods via string. Enabling r8 causes the classes and methods to change.
We're adding the proper rules to the NuGet package to -keep those.
The package structure changes to

.
├── README.md
├── Sentry.Bindings.Android.nuspec
├── [Content_Types].xml
├── _rels
├── build
│   └── net6.0-android31.0
│       └── Sentry.Bindings.Android.targets
├── lib
│   └── net6.0-android31.0
│       ├── Sentry.Bindings.Android.aar
│       ├── Sentry.Bindings.Android.dll
│       ├── Sentry.Bindings.Android.xml
│       ├── sentry-android-core-6.23.0.aar
│       └── sentry-android-ndk-6.23.0.aar
├── package
│   └── services
│       └── metadata
│           └── core-properties
│               └── 27823db434b24f20860179712cee0d5d.psmdcp
├── sentry-nuget.png
└── sentry-proguard.cfg

@bitsandfoxes bitsandfoxes merged commit 7db3f1b into main Jun 27, 2023
15 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/android-sample branch June 27, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android app using r8 crashes on SentrySdk.Init
2 participants