Add MinimumEventLevel to Sentry.Log4Net and convert events below it to breadcrumbs #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IhateTrains
requested review from
bitsandfoxes,
jamescrosswell and
SeanFeldman
as code owners
IhateTrains
changed the title
jamescrosswell
requested changes
Jul 24, 2023
There was a problem hiding this comment.
@IhateTrains thank you so much for the contribution.
I added a few comments but generally looking pretty good 👍🏻
|
This is looking great @IhateTrains ! Just the small tweak to be made to LevelMappings and then getting the build checks passing. Let me know if you need any guidance/help working out the problems with the builds. ℹ️ One tip in that respect is search for the text |
|
@jamescrosswell turns out the |
SeanFeldman
reviewed
Jul 30, 2023
jamescrosswell
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Nice work @IhateTrains ! Thanks heaps for the contribution 👍🏻
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both NLog and Serilog integrations already feature
MinimumEventLevel. I attempted to also add it for log4net, hope its implementation is acceptable to you.If
MinimumEventLevelis specified, every log4net LoggingEvent abovethresholdand belowMinimumEventLevelwill be converted to a breadcrumb.Heavily inspired by this solution from SO:
https://stackoverflow.com/a/62923187/10249243