fix: Stopping the SDK from creating DynamicSamplingContext Exception
#2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
DynamicSamplingContext Exception
There was a problem hiding this comment.
@bitsandfoxes I'm not sure I get this. Other than adding logging (when creating the dynamic sampling context from the propagation context) what has changed here?
|
The SDK is now no longer throwing exceptions. Instead of being opinionated regarding the setter being called only once we defensively handle the dynamic sampling context creation in the getter. |
Ah I see, there's no setter for DynamicSamplingContext anymore... |
jamescrosswell
requested changes
Sep 5, 2023
jamescrosswell
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2591
The scope did not copy the propagation context when being cloned. All scopes held a reference to the same context object.