Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged IHasTransactionNameSource into ITransactionContext #2654

Merged
merged 7 commits into from Sep 26, 2023

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Sep 26, 2023

Completes #2629

Migration notes

The IHasTransactionNameSource interface has been removed and the NameSource property has been moved to ITransactionContext instead.

@jamescrosswell jamescrosswell linked an issue Sep 26, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 44c691e

@jamescrosswell jamescrosswell changed the title Removed IHasTransactionNameSource Feat/4.0.0 Remov IHasTransactionNameSource Sep 26, 2023
@jamescrosswell jamescrosswell changed the title Feat/4.0.0 Remov IHasTransactionNameSource Feat/4.0.0 Remove IHasTransactionNameSource Sep 26, 2023
@jamescrosswell jamescrosswell changed the title Feat/4.0.0 Remove IHasTransactionNameSource Feat/4.0.0 deprecate IHasTransactionNameSource Sep 26, 2023
@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Sep 26, 2023
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also worht adjusting the changelog as described in the other PRs. Clarifying that this type was deleted but its member is not added to ITransaction etc.

@jamescrosswell jamescrosswell changed the title Feat/4.0.0 deprecate IHasTransactionNameSource Merged IHasTransactionNameSource into ITransactionContext Sep 26, 2023
@jamescrosswell jamescrosswell merged commit 8706936 into feat/4.0.0 Sep 26, 2023
15 checks passed
@jamescrosswell jamescrosswell deleted the feat/4.0.0-remove-hastransactionnamesource branch September 26, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IHasTransactionNameSource in v4.0.0
2 participants