New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged IHasTransactionNameSource into ITransactionContext #2654
Merged
jamescrosswell
merged 7 commits into
feat/4.0.0
from
feat/4.0.0-remove-hastransactionnamesource
Sep 26, 2023
Merged
Merged IHasTransactionNameSource into ITransactionContext #2654
jamescrosswell
merged 7 commits into
feat/4.0.0
from
feat/4.0.0-remove-hastransactionnamesource
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jamescrosswell
changed the title
Removed IHasTransactionNameSource
Feat/4.0.0 Remov IHasTransactionNameSource
Sep 26, 2023
…github.com/getsentry/sentry-dotnet into feat/4.0.0-remove-hastransactionnamesource
jamescrosswell
changed the title
Feat/4.0.0 Remov IHasTransactionNameSource
Feat/4.0.0 Remove IHasTransactionNameSource
Sep 26, 2023
jamescrosswell
changed the title
Feat/4.0.0 Remove IHasTransactionNameSource
Feat/4.0.0 deprecate IHasTransactionNameSource
Sep 26, 2023
bruno-garcia
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Also worht adjusting the changelog as described in the other PRs. Clarifying that this type was deleted but its member is not added to ITransaction
etc.
jamescrosswell
changed the title
Feat/4.0.0 deprecate IHasTransactionNameSource
Merged IHasTransactionNameSource into ITransactionContext
Sep 26, 2023
jamescrosswell
deleted the
feat/4.0.0-remove-hastransactionnamesource
branch
September 26, 2023 21:36
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #2629
Migration notes
The
IHasTransactionNameSource
interface has been removed and theNameSource
property has been moved toITransactionContext
instead.