Merged IHasMeasurements into ISpanData

CHANGELOG.md

@@ -14,6 +14,10 @@ without native/platform specific bindings and SDKs. See [this ticket for more de
 
 - Drop .NET 6 Mobile in favor of .NET 7 ([#2624](https://github.com/getsentry/sentry-dotnet/pull/2604))
 
+API Changes:
+
+- Removed IHasMeasurements ([#2659](https://github.com/getsentry/sentry-dotnet/pull/2659))
+
 ### Features
 
 - Sentry tracing middleware now gets configured automatically ([#2602](https://github.com/getsentry/sentry-dotnet/pull/2602))

src/Sentry/ITransactionData.cs

@@ -1,8 +1,59 @@
+using Sentry.Protocol;
+
 namespace Sentry;
 
 /// <summary>
 /// Immutable data belonging to a transaction.
 /// </summary>
 public interface ITransactionData : ISpanData, ITransactionContext, IEventLike
 {
+    /// <summary>
+    /// The measurements that have been set on the transaction.
+    /// </summary>
+    IReadOnlyDictionary<string, Measurement> Measurements { get; }
+
+    /// <summary>
+    /// Sets a measurement on the transaction.
+    /// </summary>
+    /// <param name="name">The name of the measurement.</param>
+    /// <param name="measurement">The measurement.</param>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    void SetMeasurement(string name, Measurement measurement);
+}
+
+/// <summary>
+/// Extensions for <see cref="ITransactionData"/>
+/// </summary>
+[EditorBrowsable(EditorBrowsableState.Never)]
+public static class TransactionDataExtensions
+{
+    /// <summary>
+    /// Sets a measurement on the transaction.
+    /// </summary>
+    /// <param name="transaction">The transaction.</param>
+    /// <param name="name">The name of the measurement.</param>
+    /// <param name="value">The value of the measurement.</param>
+    /// <param name="unit">The optional unit of the measurement.</param>
+    public static void SetMeasurement(this ITransactionData transaction, string name, int value,
+        MeasurementUnit unit = default) =>
+        transaction.SetMeasurement(name, new Measurement(value, unit));
+
+    /// <inheritdoc cref="SetMeasurement(Sentry.ITransactionData,string,int,Sentry.MeasurementUnit)" />
+    public static void SetMeasurement(this ITransactionData transaction, string name, long value,
+        MeasurementUnit unit = default) =>
+        transaction.SetMeasurement(name, new Measurement(value, unit));
+
+    /// <inheritdoc cref="SetMeasurement(Sentry.ITransactionData,string,int,Sentry.MeasurementUnit)" />
+#if !__MOBILE__
+    // ulong parameter is not CLS compliant
+    [CLSCompliant(false)]
+#endif
+    public static void SetMeasurement(this ITransactionData transaction, string name, ulong value,
+        MeasurementUnit unit = default) =>
+        transaction.SetMeasurement(name, new Measurement(value, unit));
+
+    /// <inheritdoc cref="SetMeasurement(Sentry.ITransactionData,string,int,Sentry.MeasurementUnit)" />
+    public static void SetMeasurement(this ITransactionData transaction, string name, double value,
+        MeasurementUnit unit = default) =>
+        transaction.SetMeasurement(name, new Measurement(value, unit));
 }

src/Sentry/Internal/NoOpTransaction.cs

@@ -1,3 +1,5 @@
+using Sentry.Protocol;
+
 namespace Sentry.Internal;
 
 /// <summary>
@@ -78,8 +80,16 @@ public IReadOnlyList<string> Fingerprint
     }
 
     public IReadOnlyCollection<ISpan> Spans => ImmutableList<ISpan>.Empty;
+
     public IReadOnlyCollection<Breadcrumb> Breadcrumbs => ImmutableList<Breadcrumb>.Empty;
 
     public ISpan? GetLastActiveSpan() => default;
+
     public void AddBreadcrumb(Breadcrumb breadcrumb) { }
+
+    public IReadOnlyDictionary<string, Measurement> Measurements => ImmutableDictionary<string, Measurement>.Empty;
+
+    public void SetMeasurement(string name, Measurement measurement)
+    {
+    }
 }

src/Sentry/Transaction.cs

@@ -9,7 +9,7 @@ namespace Sentry;
 /// <summary>
 /// Sentry performance transaction.
 /// </summary>
-public class Transaction : ITransactionData, IJsonSerializable, IHasDistribution, IHasTransactionNameSource, IHasMeasurements
+public class Transaction : ITransactionData, IJsonSerializable, IHasDistribution, IHasTransactionNameSource
 {
     /// <summary>
     /// Transaction's event ID.

src/Sentry/TransactionTracer.cs

@@ -7,7 +7,7 @@ namespace Sentry;
 /// <summary>
 /// Transaction tracer.
 /// </summary>
-public class TransactionTracer : ITransaction, IHasDistribution, IHasTransactionNameSource, IHasMeasurements
+public class TransactionTracer : ITransaction, IHasDistribution, IHasTransactionNameSource
 {
     private readonly IHub _hub;
     private readonly SentryOptions? _options;