Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged IHasBreadcrumbs into IEventLike #2670

Merged
merged 5 commits into from Sep 27, 2023

Conversation

jamescrosswell
Copy link
Collaborator

Removed IHasBreadcrumbs as all implementers also implemented IEventLike. I suspect this was only added because we couldn't change the public IEventLike interface.

@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Sep 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Merged IHasBreadcrumbs into IEventLike ([#2670](https://github.com/getsentry/sentry-dotnet/pull/2670))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against a20dd4c

@jamescrosswell jamescrosswell changed the title Removed IHasBreadcrumbs Feat/4.0.0 Removed IHasBreadcrumbs Sep 26, 2023
@jamescrosswell jamescrosswell changed the title Feat/4.0.0 Removed IHasBreadcrumbs Feat/4.0.0 remove IHasBreadcrumbs Sep 26, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@jamescrosswell jamescrosswell changed the title Feat/4.0.0 remove IHasBreadcrumbs Merged IHasBreadcrumbs into IEventLike Sep 26, 2023
@jamescrosswell jamescrosswell merged commit 8084c05 into feat/4.0.0 Sep 27, 2023
5 of 6 checks passed
@jamescrosswell jamescrosswell deleted the feat/4.0.0-remove-hasbreadcrumbs branch September 27, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants