Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: obsolete StackFrame.InstructionOffset #2689

Merged
merged 3 commits into from Oct 3, 2023
Merged

chore: obsolete StackFrame.InstructionOffset #2689

merged 3 commits into from Oct 3, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 3, 2023

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Oct 3, 2023 •
edited

Can we merge this into feat/4.0.0?

@vaind
Copy link
Collaborator Author

vaind commented Oct 3, 2023

Can we merge this into feat/4.0.0?

I'm prepping another PR for v4 that removes this directly

@vaind vaind enabled auto-merge (squash) October 3, 2023 11:18
@vaind vaind merged commit 8cd3194 into main Oct 3, 2023
15 checks passed
@vaind vaind deleted the chore/update-stackframe-attributes branch October 3, 2023 11:33
@vaind vaind mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell jamescrosswell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaind @bitsandfoxes