Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed IUserFactory in favor of ISentryUserFactory #2840

Merged
merged 7 commits into from Nov 17, 2023

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Nov 15, 2023

If I got that right:
Sentry's ServiceCollectionExtension adds the HttpContextAccessor.

That way the DefaultUserFactory is able to access the context and no longer requires it to be passed down.

Also resolves #2844

@jamescrosswell
Copy link
Collaborator

That way the DefaultUserFactory is able to access the context and no longer requires it to be passed down.

Exactly, yeah.

Might be worth checking if this is related, while we're making changes here:

@bitsandfoxes
Copy link
Contributor Author

Might be worth checking if this is related, while we're making changes here:

Yes. It coincidentally fixes this issue.

@vaind vaind merged commit 749c9a7 into feat/4.0.0 Nov 17, 2023
17 checks passed
@vaind vaind deleted the fix/remove-iuserfactory branch November 17, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants