Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SentryOptions.AutoRegisterTracing #2871

Merged
merged 6 commits into from Nov 22, 2023
Merged

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Nov 20, 2023

Resolves #2865

Needs corresponding documentation when released.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

Added what I thought made sense but ESL so maybe it was right originally

src/Sentry.AspNetCore/SentryAspNetCoreOptions.cs Outdated Show resolved Hide resolved
src/Sentry.AspNetCore/SentryTracingMiddlewareExtensions.cs Outdated Show resolved Hide resolved
jamescrosswell and others added 2 commits November 21, 2023 20:20
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@bruno-garcia
Copy link
Member

Windows CI failed twice in a row: 1 and 2

@jamescrosswell
Copy link
Collaborator Author

Windows CI failed twice in a row: 1 and 2

Yeah it started failing on all the PRs for the main branch... but just before I was about to go to sleep so haven't had a chance to look at it yet. You can see neither of the changes in this PR caused it (they were your changes to code comments). This is a non-deterministic CI problem again... probably GitHub updated their windows runner or something.

@jamescrosswell jamescrosswell merged commit 65a7bba into main Nov 22, 2023
14 checks passed
@jamescrosswell jamescrosswell deleted the autoregistertracing_option branch November 22, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SentryOptions.AutoRegisterTracing flag to options
3 participants