Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename platform specific code from iOS to Cocoa #2929

Merged
merged 2 commits into from Dec 1, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 30, 2023

No description provided.

@vaind vaind marked this pull request as ready for review December 1, 2023 07:46
@vaind vaind enabled auto-merge (squash) December 1, 2023 08:31
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly satisfying to see the Ios go away. Looked wrong from the beginning.

Comment on lines 26 to 27
<Compile Remove="**\*.iOS.cs" />
<Compile Remove="**\iOS\**\*.cs" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get those. Do you mean the Maui tests?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@vaind vaind merged commit 57910db into main Dec 1, 2023
20 checks passed
@vaind vaind deleted the refactor/cocoa-rename branch December 1, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants