Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xcodebuild archive to build sentry-cocoa #2960

Merged
merged 3 commits into from Dec 8, 2023

Commits on Dec 7, 2023

  1. Use xcodebuild archive to build sentry-cocoa

    Fixes getsentry#2954
    
    Without the "archive" command xcodebuild will build with code coverage enabled (`-fprofile-instr-generate` is passed to clang) and that links in the compiler profiling runtime.
    This is evidenced by the `__llvm_profile_runtime` symbol being present in the `Sentry` binary with `nm`. The static initializer will hook up profiling and we get a `default.profraw` file when the app exits.
    
    The fix is to use the "archive" command instead, similar to how upstream sentry-cocoa uses it here: https://github.com/getsentry/sentry-cocoa/blob/ddb47781bffd76406f31ab43e66760362585fcd7/Makefile#L82-L83
    akoeplinger committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4a57128 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    akoeplinger committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    74dc0d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Configuration menu
    Copy the full SHA
    9327f1c View commit details
    Browse the repository at this point in the history