Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotlight #2961

Merged
merged 8 commits into from
Dec 13, 2023
Merged

spotlight #2961

merged 8 commits into from
Dec 13, 2023

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Dec 9, 2023 •
edited

Resolves: #2955

Logo for .NET added via:

image image

Thoughts:

  • We should have an env var to enable it. ENABLE_SPOTLIGHT (purposely not prefixed with SENTRY?)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023 •
edited

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f5efe1c

@bruno-garcia bruno-garcia marked this pull request as ready for review December 12, 2023 23:18
@bruno-garcia
Copy link
Member Author

bruno-garcia commented Dec 12, 2023 •
edited

Needs tests though

@bruno-garcia bruno-garcia mentioned this pull request Dec 13, 2023
Merged
bitsandfoxes
bitsandfoxes approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bruno-garcia bruno-garcia merged commit a9e8acd into main Dec 13, 2023
19 checks passed
@bruno-garcia bruno-garcia deleted the feat/spotlight branch December 13, 2023 15:44
This was referenced Dec 13, 2023
Closed
Closed
Closed
Closed
vaind pushed a commit that referenced this pull request Dec 27, 2023
@bruno-garcia @vaind
spotlight (#2961)
d60af85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell jamescrosswell is a code owner

@Giorgi Giorgi Awaiting requested review from Giorgi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spotlight support
2 participants
@bruno-garcia @bitsandfoxes