Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Renamed Sentry.Runtime to SentryRuntime #3016

Merged
merged 13 commits into from Jan 11, 2024

Conversation

bitsandfoxes
Copy link
Contributor

No description provided.

@bitsandfoxes bitsandfoxes changed the title feat: Renamed Sentry.Runtime to SentryRuntime` feat: Renamed Sentry.Runtime to SentryRuntime Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fa57326

Base automatically changed from feat/rename-user-sentryuser to main January 8, 2024 17:14
CHANGELOG.md Outdated
Comment on lines 9 to 11
- Renamed `Sentry.User` to `SentryUser` ([#3015](https://github.com/getsentry/sentry-dotnet/pull/3015))
- Renamed `Sentry.Runtime` to `SentryRuntime` ([#3016](https://github.com/getsentry/sentry-dotnet/pull/3016))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Renamed `Sentry.User` to `SentryUser` ([#3015](https://github.com/getsentry/sentry-dotnet/pull/3015))
- Renamed `Sentry.Runtime` to `SentryRuntime` ([#3016](https://github.com/getsentry/sentry-dotnet/pull/3016))
- Class renamed `Sentry.User` to `Sentry.SentryUser` ([#3015](https://github.com/getsentry/sentry-dotnet/pull/3015))
- Class renamed `Sentry.Runtime` to `Sentry.SentryRuntime` ([#3016](https://github.com/getsentry/sentry-dotnet/pull/3016))

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1f71379) 67.56% compared to head (fa57326) 76.40%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 50.00% 1 Missing and 2 partials ⚠️
src/Sentry/PlatformAbstractions/SentryRuntime.cs 80.00% 1 Missing ⚠️
src/Sentry/Protocol/SampleProfile.cs 0.00% 0 Missing and 1 partial ⚠️
src/Sentry/SentryOptions.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3016      +/-   ##
==========================================
+ Coverage   67.56%   76.40%   +8.84%     
==========================================
  Files         393      351      -42     
  Lines       14354    13234    -1120     
  Branches     2866     2643     -223     
==========================================
+ Hits         9698    10112     +414     
+ Misses       4019     2445    -1574     
- Partials      637      677      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
bitsandfoxes and others added 5 commits January 9, 2024 11:18
* Replaced Coverlet with Microsoft.CodeCoverage

* Update Directory.Build.props

* Changed from microsoft.codecoverage to coverlet.collector
…3037)

* Update CONTRIBUTING.md

* Renamed Sentry.NoMobile.sln to .generated.NoMobile.sln
@bitsandfoxes bitsandfoxes merged commit bb71eaf into main Jan 11, 2024
20 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/rename-runtime-sentryruntime branch January 11, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants