Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sentry to global usings #3043

Merged
merged 8 commits into from Jan 12, 2024
Merged

add sentry to global usings #3043

merged 8 commits into from Jan 12, 2024

Conversation

bruno-garcia
Copy link
Member

Now that this is complete:

We can enable namespace Sentry by default

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- add sentry to global usings ([#3043](https://github.com/getsentry/sentry-dotnet/pull/3043))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d80a52a

@bruno-garcia
Copy link
Member Author

Actually the opt-out could be simpler, as Simon said here:

#1487 (comment)

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbf8fac) 76.39% compared to head (1b1d0c0) 76.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3043   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files         351      351           
  Lines       13257    13257           
  Branches     2645     2645           
=======================================
  Hits        10128    10128           
  Misses       2450     2450           
  Partials      679      679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bruno-garcia
Copy link
Member Author

Added back SentryImplicitUsings for opt-out because on generated code, it causes compilation error, so the ItemGroup Using Remove=Sentry approach didn't work.

@bruno-garcia bruno-garcia enabled auto-merge (squash) January 12, 2024 04:23
@bruno-garcia bruno-garcia merged commit 24c159f into main Jan 12, 2024
7 of 8 checks passed
@bruno-garcia bruno-garcia deleted the feat/sentry-in-global-usings branch January 12, 2024 10:56
vaind pushed a commit that referenced this pull request Jan 12, 2024
@frankbuckley
Copy link

This clashes all over the place for me - and let alone our own types, obvious core library types - e.g.:

error CS0104: 'ISession' is an ambiguous reference between 'Microsoft.AspNetCore.Http.ISession' and 'Sentry.ISession'

It is a huge assumption to think that library users want using Sentry inkected into every source file in their projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants