Fix BackgroundWorker exiting when OperationCanceledException is not from shutdown request #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipcaofph
requested review from
bitsandfoxes and
jamescrosswell
as code owners
…rom shutdown request
phillipcaofph
force-pushed
the
backgroundworking-http-timeout-fix
branch
from
672fa0a
to
c6de67f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
==========================================
+ Coverage 75.73% 76.95% +1.22%
==========================================
Files 357 371 +14
Lines 13466 13898 +432
Branches 2671 2754 +83
==========================================
+ Hits 10198 10695 +497
+ Misses 2593 2503 -90
- Partials 675 700 +25 ☔ View full report in Codecov by Sentry. |
|
Hey @phillipcaofph, thanks for contributing! The change absolutely makes sense and I'd love to merge this but we first need to figure out the testing situation as it touches some very internal bits. Thanks for your patience. |
jamescrosswell
requested changes
Apr 15, 2024
jamescrosswell
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3274