Adds ability to specify user values via NLog configuration #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 92.23% 92.06% -0.17%
==========================================
Files 81 82 +1
Lines 2073 2092 +19
==========================================
+ Hits 1912 1926 +14
- Misses 161 166 +5
Continue to review full report at Codecov.
|
bruno-garcia
requested changes
Jan 14, 2020
bruno-garcia
approved these changes
Jan 14, 2020
|
❤️ ! |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #322
I opted to have a user object to keep the user information logically coupled. If it would be more clear in another format I'm fine with changing it, but I also figured it would be more straightforward to do it this way especially if we want to add support for structured contexts or other things (i.e. fingerprint) for them to be logically structured like in sentry documentation.