Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Minimal Blazor support #3386

Merged
merged 24 commits into from
Jun 19, 2024
Merged

feat: Minimal Blazor support #3386

merged 24 commits into from
Jun 19, 2024

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented May 24, 2024

Copy link
Contributor

github-actions bot commented May 24, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1796464

@bitsandfoxes bitsandfoxes marked this pull request as ready for review May 28, 2024 15:43
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea of this entry point to start the project!!

.generated.NoMobile.sln Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Program.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitsandfoxes it looks like the even that comes through to Sentry is being marked as Handled even though the exception is not caught... but I think we have a separate issue to track this as it's an issue with our logging integration rather than our blazor wasm integration:

The other thing that is a bit confusing is that the Nav menu is titled "Throw, Catch and Capture" even though the code is just doing a throw.

image

I had to look at the code to work out that this was a nav menu actually... initially I though that clicking on that link would throw, catch and capture and exception (one with handled=true) and that clicking on the button would throw and unhandled exception... demonstrating that the integration will catch both kinds of exceptions.

So overall, the integration itself looks great... but the Sample project is quite confusing. I think it's worth tweaking the UI in the sample project to make this less confusing.

@bitsandfoxes
Copy link
Contributor Author

Super fair point with the sample! I've updated it and added some buttons and some navigation.
It can now throw and it shows up as unhandled
Screenshot 2024-06-18 at 23 27 37

and throw and capture and it shows up as handled.
Screenshot 2024-06-18 at 23 27 44

@jamescrosswell
Copy link
Collaborator

I've updated it and added some buttons and some navigation.

Cool, I added a couple of styles to make the nav a bit more apparent and somewhat "Sentry" looking 😉

image

@jamescrosswell jamescrosswell merged commit eb73e2e into main Jun 19, 2024
20 checks passed
@jamescrosswell jamescrosswell deleted the feat/blazor-base branch June 19, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry support for Blazor WebAssembly
4 participants