Fixed exception when DangerousDisablePathAndQueryCanonicalization = true #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueryCanonicalization = true
| { | ||
| // This is a safe way to get the HttpRequestUrl, even when DisablePathAndQueryCanonicalization is true | ||
| // See https://github.com/getsentry/sentry-dotnet/issues/3387 | ||
| return new UriBuilder(uri).Uri.GetComponents(UriComponents.HttpRequestUrl, UriFormat.Unescaped); |
There was a problem hiding this comment.
I thought calling .GetComponents() is the reason for this issue?
There was a problem hiding this comment.
I see, because it's wrapped in the UriBuilder.
bitsandfoxes
approved these changes
May 27, 2024
Unfortunately not. The flags and properties indicating The only other option is a try/catch... which would be cheaper if/when this error does not occur but would be very expensive when this error does occur. We could do that - it would avoid allocation of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3387