Fixed null IServiceProvider in anonymous routes with OpenTelemetry #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
reviewed
Jun 3, 2024
| // Although the compiler suggests context.RequestServices cannot be null, in practice it can be, so we | ||
| // have a null check here. | ||
| // See: https://github.com/getsentry/sentry-dotnet/issues/3395 | ||
| var userFactory = context.RequestServices?.GetService<ISentryUserFactory>(); |
There was a problem hiding this comment.
Fair enough. But how do we end up in a state where we cannot locate an ISentryuserFactory?
There was a problem hiding this comment.
If we had a service collection reference, I think we'd find an ISentryUserFactory registered on it. I'm not sure what set of circumstances leads to context.RequestServices being null. That would require debugging some of the MS code, I think (or possibly the OpenTelemetry codebase).
Since, in this case, the reference will only be null when nobody is logged in, it doesn't present any difficulty to us... we leave the user context empty in this case (exactly what we want).
bitsandfoxes
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3395