Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert adding an EventScrubber #3441

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

I jumped the gun here and bought into what the Python SDK is doing too early.
After talking to @bruno-garcia there are a bunch of things to consider. The most glaring ones:

  • The SDK should not grab any sensitive data by default. So there should not be a need to scrub things we know that should not be there from the event after the fact.
  • Scrubbing the stacktrace: That'd open a whole can of worms for grouping.

We should take the issues regarding "The SDK is grabbing X" and "The SDK is not filtering Y" on a one-by-one basis and look into those, instead of creating a blanket scrubbing solution.

#skip-changelog

@bitsandfoxes bitsandfoxes merged commit c12fc96 into main Jun 21, 2024
20 checks passed
@bitsandfoxes bitsandfoxes deleted the chore/revert-eventscrubbing branch June 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants