fix: set score url to fully constructed url #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_url fix: set score url to fully constructed url
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 93.33% 93.02% -0.32%
==========================================
Files 117 107 -10
Lines 2806 2681 -125
==========================================
- Hits 2619 2494 -125
Misses 187 187Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Feb 24, 2020
16 tasks
|
No problem! When would we see a new release with this included? |
|
@christopher-taormina-zocdoc it's already indexed by nuget: version: 2.1.0 |
|
@bruno-garcia Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Url property on scope was only set as the path from the HttpContext. This is not the fully constructed url of the request and sending only the path here breaks some functionality in the Sentry UI.
This addresses #366.