Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public members IReadOnly instead of Immutable #37

Merged
merged 10 commits into from
Jul 10, 2018

Conversation

bruno-garcia
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 7, 2018

Codecov Report

Merging #37 into master will increase coverage by 1.35%.
The diff coverage is 92.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   94.62%   95.98%   +1.35%     
==========================================
  Files          69       70       +1     
  Lines        1692     1717      +25     
==========================================
+ Hits         1601     1648      +47     
+ Misses         91       69      -22
Impacted Files Coverage Δ
src/Sentry/Protocol/Context/Device.cs 47.36% <ø> (ø) ⬆️
src/Sentry/Protocol/Context/OperatingSystem.cs 40% <ø> (ø) ⬆️
src/Sentry/Protocol/Context/App.cs 41.17% <ø> (ø) ⬆️
src/Sentry/Protocol/Context/Runtime.cs 36.36% <ø> (ø) ⬆️
src/Sentry/Protocol/Context/Browser.cs 28.57% <ø> (ø) ⬆️
src/Sentry/Protocol/Breadcrumb.cs 100% <ø> (ø) ⬆️
src/Sentry/Internal/MainExceptionProcessor.cs 100% <100%> (ø) ⬆️
...y/Infrastructure/ConcurrentDictionaryExtensions.cs 100% <100%> (ø)
src/Sentry.AspNetCore/AspNetCoreEventProcessor.cs 100% <100%> (ø)
src/Sentry/SentryClient.cs 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981eeb7...7a6f89d. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 91be305 into master Jul 10, 2018
@bruno-garcia bruno-garcia deleted the feat/scope-management branch July 10, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants