Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure provider gets disposed on app shutdown #40

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

bruno-garcia
Copy link
Member

* Registering a type ensures when resolved, lifetime is owned by the container which disposes it on shutdown.
* Resolves aspnet/Hosting/issues/1466
@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #40 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   95.98%   95.98%   +<.01%     
==========================================
  Files          70       70              
  Lines        1717     1718       +1     
==========================================
+ Hits         1648     1649       +1     
  Misses         69       69
Impacted Files Coverage Δ
...try.Extensions.Logging/LoggingBuilderExtensions.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bff31...6817e24. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 410b9a2 into master Jul 10, 2018
@bruno-garcia bruno-garcia deleted the bug/logging-provider-dispose branch July 10, 2018 17:32
bruno-garcia added a commit that referenced this pull request Dec 17, 2019
lucas-zimerman added a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoggerFactory.Dispose not called on app shutdown
2 participants