Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich transactions with more data #875

Merged
merged 12 commits into from
Mar 9, 2021
Merged

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Mar 4, 2021

No description provided.

@Tyrrrz Tyrrrz added Feature New feature or request Product: Performance labels Mar 4, 2021
@Tyrrrz Tyrrrz added this to In Progress in v3.x Mar 4, 2021
@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #875 (276a540) into main (5782695) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   80.91%   80.96%   +0.04%     
==========================================
  Files         177      178       +1     
  Lines        5654     5653       -1     
  Branches     1410     1407       -3     
==========================================
+ Hits         4575     4577       +2     
  Misses        661      661              
+ Partials      418      415       -3     
Impacted Files Coverage Δ
src/Sentry.AspNetCore/SentryTracingMiddleware.cs 72.46% <100.00%> (+1.69%) ⬆️
src/Sentry/Internal/Enricher.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/Hub.cs 69.91% <100.00%> (-1.51%) ⬇️
src/Sentry/Internal/MainSentryEventProcessor.cs 95.23% <100.00%> (-1.71%) ⬇️
src/Sentry/SentryOptionsExtensions.cs 71.42% <100.00%> (ø)
...grations/TaskUnobservedTaskExceptionIntegration.cs 100.00% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5782695...276a540. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to a great direction!

src/Sentry/Internal/Enricher.cs Outdated Show resolved Hide resolved
src/Sentry/Internal/Enricher.cs Show resolved Hide resolved
src/Sentry/Internal/Hub.cs Outdated Show resolved Hide resolved
@Tyrrrz Tyrrrz marked this pull request as ready for review March 4, 2021 22:50
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Mar 4, 2021

Sample:

image

@Tyrrrz Tyrrrz requested a review from bruno-garcia March 5, 2021 13:54
@bruno-garcia bruno-garcia enabled auto-merge (squash) March 6, 2021 16:52
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Mar 9, 2021

Suddenly failing consistently now, but only on Windows:

Error: Sentry.Tests.Internals.Http.CachingTransportTests.DoesNotDeleteCacheIfConnectionWithIssue: Test execution timed out after 7000 milliseconds
  Failed Sentry.Tests.Internals.Http.CachingTransportTests.DoesNotDeleteCacheIfConnectionWithIssue [1 ms]
  Error Message:
   Test execution timed out after 7000 milliseconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Product: Performance
Projects
No open projects
v3.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants