Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add version prefix in release if it's already set #877

Merged
merged 5 commits into from
Mar 9, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Mar 5, 2021

Closes #873

@Tyrrrz Tyrrrz added the Feature New feature or request label Mar 5, 2021
@Tyrrrz Tyrrrz added this to In Progress in v3.x Mar 5, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia enabled auto-merge (squash) March 6, 2021 16:48
@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #877 (3c0d0a3) into main (5782695) will decrease coverage by 1.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   80.91%   79.14%   -1.78%     
==========================================
  Files         177      177              
  Lines        5654     5657       +3     
  Branches     1410     1411       +1     
==========================================
- Hits         4575     4477      -98     
- Misses        661      771     +110     
+ Partials      418      409       -9     
Impacted Files Coverage Δ
src/Sentry/Internal/ApplicationVersionLocator.cs 80.00% <100.00%> (+5.00%) ⬆️
src/Sentry/Internal/Polyfills.cs 75.00% <100.00%> (+1.66%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-71.24%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 33.33% <0.00%> (-66.67%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5782695...3c0d0a3. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 314e169 into main Mar 9, 2021
@bruno-garcia bruno-garcia deleted the release-prefix-fix branch March 9, 2021 17:09
@Tyrrrz Tyrrrz moved this from In Progress to Done in v3.x Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
No open projects
v3.x
Done
Development

Successfully merging this pull request may close these issues.

Only include release prefix if it doesn't already exist
3 participants