Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for testing user data w/ exception #210

Closed
wants to merge 1 commit into from
Closed

Add e2e test for testing user data w/ exception #210

wants to merge 1 commit into from

Conversation

crussell52
Copy link

@crussell52 crussell52 commented Jan 10, 2020 •
edited
Loading

Test to demonstrate #195

@crussell52
Copy link
Author

This test assumes that testServer.events[0].event.data.user is the correct place to look for user data, but that is mostly a guess since this seems to be the first e2e test that looks for user data.

@crussell52 crussell52 force-pushed the no-user-data-test branch 2 times, most recently from 9d53205 to c2e8a58 Compare January 10, 2020 23:07
@crussell52 crussell52 mentioned this pull request Jan 13, 2020
Closed
@HazAT
Copy link
Member

HazAT commented Jul 3, 2020 •
edited
Loading

We're going to take a look at it.

@HazAT
Copy link
Member

HazAT commented Jul 14, 2020

Thanks for the investigation, superseded by #242

@HazAT HazAT closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crussell52 @HazAT