-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default environment name #524
Comments
This is also strange, because this library uses |
Kind of related to #503 The whole configuration managements needs some love |
whatyouhide
changed the title
default environment is unexpected :prod by default
Default environment is unexpected :prod by default
Jul 12, 2023
whatyouhide
changed the title
Default environment is unexpected :prod by default
Fix default environment name
Jul 12, 2023
whatyouhide
added a commit
that referenced
this issue
Aug 3, 2023
whatyouhide
added a commit
that referenced
this issue
Aug 9, 2023
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because
Mix.env()
is by default:prod
for dependencies, locally, the default Sentry environment is:prod
, which is not intuitive when you run an app locally indev
mode.I think the intended behavior was to use the Mix env of the parent app but that's not what's happening right now (not sure if it's possible to get it).
Edit from Andrea (maintainer)
We should require
:environment_name
to be set, I agree. Let's do a few things.Tasks
The text was updated successfully, but these errors were encountered: