feat(source packaging): allow custom output path in task #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
requested changes
Feb 12, 2024
There was a problem hiding this comment.
The issue with this is that the priv/sentry.map path is not public API. So, if allow users to change the output of the map, we should also allow them to load the map from a different path. So, let's also add a config option for this, called :source_code_map_path. When not present, we default to the current priv/sentry.map.
…option to load from such path
razielgn
force-pushed
the
allow-override-of-package-source-code-task-output
branch
from
58a6102
to
7bd03ab
Compare
|
Thank you for the tips, I've updated the PR. I hope I added |
whatyouhide
approved these changes
Feb 24, 2024
|
Thanks @razielgn! 💟 |
razielgn
deleted the
allow-override-of-package-source-code-task-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes packaging an app's source code for Sentry v10 when building in highly reproducible environments (like nix), where the deps' sources are read-only (i.e. cannot write to Sentry's
privdir).I've added an example to the docs.