Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx monitor slug in Oban + Quantum integrations #721

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

whatyouhide
Copy link
Collaborator

Closes #720.

lib/sentry/integrations/oban/cron.ex Outdated Show resolved Hide resolved
lib/sentry/config.ex Show resolved Hide resolved
Co-authored-by: Milton Mazzarri <me@milmazz.uno>
@whatyouhide
Copy link
Collaborator Author

@milmazz this is a first pass to get things working, but I suspect we'll want some level of customization here anyway. I don't want to figure out the API now though, I just want to get this fixed for now so that we have time to give it some more thought.

Copy link
Contributor

@milmazz milmazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After editing the monitor slug via Sentry UI, it's working 🎉

lib/sentry/integrations/quantum/cron.ex Show resolved Hide resolved
Co-authored-by: Milton Mazzarri <me@milmazz.uno>
@whatyouhide whatyouhide merged commit c26a782 into master Apr 19, 2024
2 of 3 checks passed
@whatyouhide whatyouhide deleted the al/fix-monitor-slug branch April 19, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron Monitor integration for Oban
2 participants