Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in call_sentry_cli: no return value #139

Closed
lhunath opened this issue Jul 5, 2022 · 3 comments · Fixed by #140
Closed

Regression in call_sentry_cli: no return value #139

lhunath opened this issue Jul 5, 2022 · 3 comments · Fixed by #140

Comments

@lhunath
Copy link

lhunath commented Jul 5, 2022

Regression from: 6830837

SentryHelper.call_sentry_cli appears to no longer return its output as a return value.

Most uses of this utility do not care about the return value, but fallback_sentry_cli_auth does, since it uses it to parse the sentry config status.

This now fails since the return value is nil:

ERROR [2022-07-05 11:25:39.31]: no implicit conversion of nil into String
@lhunath
Copy link
Author

lhunath commented Jul 5, 2022

cc @kamilogorek

@philipphofmann
Copy link
Member

Thanks for reporting this, @lhunath. @kamilogorek, could you have a look, please?

@lhunath
Copy link
Author

lhunath commented Jul 13, 2022

Please bump the release; the broken .1 release is a blocker for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants