Allow manually specifying android mapping-uuid

[mateuszkwiecinski]

#79

I gave it a try and tried adding uuid support to the plugin. I basically allow passing almost all sentry-cli parameters, leaving the validation up to sentry-cli.

Please note I'm not familiar with Ruby so I havily relied on other parts of the codebase + code hints and Rubocop offenses that were highlithed. I also didn't know how to write proper tests, I only found ones relying on mocks so I don't actually know if the feature works now.

[mateuszkwiecinski]

AFAIU This validation was never invoked, as the framework checks its valie using ConfigItem's verify_block block

[mateuszkwiecinski]

I'm using File.file? as I understood we don't support passing a directory

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[mateuszkwiecinski]

Wow! You've ignored this PR for more than a year, and now you're sending an automated bot to close it with a dummy quote that doesn't explain anything except "hey, this PR will be closed". That's... not nice

---

"Sometimes when I close my eyes, I can’t see." ― _ Anonymous_ 🥀

[philipphofmann]

Hey @mateuszkwiecinski,

Thanks for opening up this PR a year ago. We added a stale bot not to close issues but to remind us when a PR is stale. We did this to stop ignoring PRs. The bot explains this:

This pull request has gone three weeks without activity. In another week, I will close it.

I apologize for not reviewing it. If you still are motivated to finish this PR, please reopen it, ping me, and you will get a review.

[posativ]

The PR has a lot of code, if you just want to upload a mapping with a pre-generated UUID already present in AndroidManifest.xml using <meta-data android:name="io.sentry.proguard-uuid" android:value="A_VALID_UUID" /> you can use the following private lane:

#!/usr/bin/env ruby

require "rexml/document"

# […]

KEY_FLAVOR = "FLAVOR"

KEY_SENTRY_ORG_SLUG = "SENTRY_ORG_SLUG"
KEY_SENTRY_PROJECT_SLUG = "SENTRY_PROJECT_SLUG"

# […]

platform :android do

  # […]

  # Retrieve UUID and upload mapping.txt to Sentry: https://docs.sentry.io/product/cli/dif/
  private_lane :upload_mapping do
    Dir.chdir("..") do
      flavor = ENV[KEY_FLAVOR]  # or lane_context[SharedValues::ENVIRONMENT] or just "live" etc.
      xml = REXML::Document.new(File.new("app/build/intermediates/merged_manifest/#{flavor}Release/AndroidManifest.xml"))
      uuid = REXML::XPath.first(xml, '//manifest/application/meta-data[@android:name="io.sentry.proguard-uuid"]/@android:value').value

      command = ["sentry-cli"]
      command << "upload-proguard"
      command << "app/build/outputs/mapping/#{flavor}Release/mapping.txt"
      command << "--uuid" << uuid
      command << "--org" << ENV[KEY_SENTRY_ORG_SLUG]
      command << "--project" << ENV[KEY_SENTRY_PROJECT_SLUG]
      sh command
    end
  end

along with some environment variables

FLAVOR = live

SENTRY_ORG_SLUG = your-org
SENTRY_PROJECT_SLUG = your-project

[philipphofmann]

Thanks for sharing the workaround @posativ 😊